New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate combobox to mwc #11546
Migrate combobox to mwc #11546
Conversation
@@ -3,7 +3,7 @@ import "@polymer/paper-input/paper-input"; | |||
import "@polymer/paper-item/paper-item"; | |||
import "@polymer/paper-item/paper-item-body"; | |||
import "@polymer/paper-listbox/paper-listbox"; | |||
import "@vaadin/vaadin-combo-box/theme/material/vaadin-combo-box-light"; | |||
import "@vaadin/combo-box/theme/material/vaadin-combo-box-light"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -2,7 +2,7 @@ import { mdiCheck, mdiClose, mdiMenuDown, mdiMenuUp } from "@mdi/js"; | |||
import "@polymer/paper-input/paper-input"; | |||
import "@polymer/paper-item/paper-icon-item"; | |||
import "@polymer/paper-item/paper-item-body"; | |||
import "@vaadin/vaadin-combo-box/theme/material/vaadin-combo-box-light"; | |||
import "@vaadin/combo-box/theme/material/vaadin-combo-box-light"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few empty combobox issues left, rest looks good 👍
I just converted the base element now, not all comboboxes use the base element yet, that is the next step and should make all comboboxes look the same and good :-) |
Fantastic. Thanks for jumping right on this @bramkragten et al. |
Proposed change
Migrates combo box to mwc
Next step, migrate all comboboxes to use
ha-combobox
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: