Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Automation Action Choose to HA Form #11597

Merged
merged 3 commits into from Feb 7, 2022
Merged

Convert Automation Action Choose to HA Form #11597

merged 3 commits into from Feb 7, 2022

Conversation

zsarnett
Copy link
Contributor

@zsarnett zsarnett commented Feb 7, 2022

Breaking change

Proposed change

Changing automation Editors to HA Form

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett merged commit 9eea17b into dev Feb 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the Automation-Choose branch February 7, 2022 23:45
@balloob
Copy link
Member

balloob commented Feb 7, 2022

When all forms migrated, we should make sure all ha-form related components (including selectors and this action component) are in the ha-form folder so it's easier to indicate that one should use ha-form.

.hass=${this.hass}
.schema=${[{ name: "sequence", selector: { action: {} } }]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't create static objects in render, as they will be recreated on every render (every state change), they will not pass a strict equality check and thus will cause a re-render down the line while not needed.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants