Replace checkboxes in list items with check-list-item
#11610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Feb 8, 2022
src/components/ha-check-list-item.ts
Outdated
| import { CheckListItem } from "@material/mwc-list/mwc-check-list-item"; | ||
| import { customElement } from "lit/decorators"; | ||
|
|
||
| const styles = [ |
There was a problem hiding this comment.
Why define above and not use static styles = […] ?
balloob
reviewed
Feb 8, 2022
balloob
reviewed
Feb 8, 2022
src/components/ha-radio.ts
Outdated
| @@ -1,11 +1,19 @@ | |||
| import { Radio } from "@material/mwc-radio"; | |||
There was a problem hiding this comment.
Should we go all fancy and import just the base and the styles? like this
balloob
previously approved these changes
Feb 8, 2022
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
balloob
approved these changes
Feb 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: