Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial focus for device, area, and entity dialogs #11622

Merged
merged 4 commits into from Feb 9, 2022
Merged

Set initial focus for device, area, and entity dialogs #11622

merged 4 commits into from Feb 9, 2022

Conversation

steverep
Copy link
Member

@steverep steverep commented Feb 9, 2022

Proposed change

Dialog Module Initial Focus
dialog-area-registry-detail Name field
dialog-device-registry-detail Name field
dialog-entity-editor Settings tab
ha-more-info-dialog Details tab if present, otherwise content

There are 71 dialogs in the UI, the majority of which need initial focus set, so this will be the first of several pull requests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

@bramkragten bramkragten merged commit 4db943c into home-assistant:dev Feb 9, 2022
@steverep steverep deleted the common-dialog-focus branch February 9, 2022 20:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2022
@steverep steverep linked an issue Aug 13, 2022 that may be closed by this pull request
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal dialogs need keyboard focus management
4 participants