New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Sun to Ha Form #11647
Merged
Merged
Convert Sun to Ha Form #11647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsarnett
added
the
needs design preview
PRs with this label will trigger a GitHub action to generate a gallery preview
label
Feb 10, 2022
balloob
reviewed
Feb 10, 2022
public static get defaultConfig() { | ||
return { | ||
event: "sunrise" as SunTrigger["event"], | ||
offset: 0, | ||
}; | ||
} | ||
|
||
protected firstUpdated(): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also use memoizeOne
zsarnett
force-pushed
the
Sun-Trigger-to-Form
branch
from
February 10, 2022 21:04
22ac93a
to
dc03306
Compare
balloob
reviewed
Feb 10, 2022
src/panels/config/automation/trigger/types/ha-automation-trigger-sun.ts
Outdated
Show resolved
Hide resolved
balloob
previously approved these changes
Feb 10, 2022
…er-sun.ts Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
balloob
approved these changes
Feb 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
needs design preview
PRs with this label will trigger a GitHub action to generate a gallery preview
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: