Improve robustness of hls media player #11672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve robustness of hls media player by retrying errors following the recommended approach in the HLS docs: https://github.com/video-dev/hls.js/blob/master/docs/API.md#fatal-error-recovery This change introduces two types of errors: - Fatal errors that make the video element disappear (the old way all errors are handled) - Retryable errors that show a banner on the top of the screen while a retry is invoked The error state is reset in a couple places based on HLS player making progress (e.g. loading a manifest or loading an actual fragment). The error messages are simplified a bit too while we are here since the existing error codes are jarring, and don't actually provide that much extra detail.
balloob
approved these changes
Feb 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve robustness of hls media player by retrying errors following the recommended approach in the HLS docs: https://github.com/video-dev/hls.js/blob/master/docs/API.md#fatal-error-recovery
This change introduces two types of errors:
The error state is reset in a couple places based on HLS player making progress (e.g. loading
a manifest or loading an actual fragment).
The error messages are simplified a bit too while we are here since the existing error codes are jarring, and don't
actually provide that much extra detail.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: