Omit Device info and actions for connected controller nodes #11673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Don't show Device info and actions that aren't applicable to "connected" Z-Wave controller nodes.
A "connected" controller node is the Z-Wave controller that the driver is talking to directly over the serial API. These controller nodes do not support device information and actions that other nodes in the network do. It can be confusing to users to see information that is incorrect, such as no support for Z-Wave Plus or Security.
Info not applicable:
Actions not supported:
Using the
is_controller_node
property of a node, we can omit the above when the connected controller device is selected. Depends on core PR home-assistant/core#66404.Type of change
Additional information
Before:
After:
This is also the approach zwavejs2mqtt took for hiding the device info (they did not disable any actions though). See issue zwave-js/zwave-js-ui#1886. In comparison:
If there's a better way to communicate this, I'm open to implementing other ideas.
Checklist
If user exposed functionality or configuration variables are added/changed: