Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit Device info and actions for connected controller nodes #11673

Merged
merged 1 commit into from Feb 14, 2022
Merged

Omit Device info and actions for connected controller nodes #11673

merged 1 commit into from Feb 14, 2022

Conversation

kpine
Copy link
Contributor

@kpine kpine commented Feb 13, 2022

Proposed change

Don't show Device info and actions that aren't applicable to "connected" Z-Wave controller nodes.

A "connected" controller node is the Z-Wave controller that the driver is talking to directly over the serial API. These controller nodes do not support device information and actions that other nodes in the network do. It can be confusing to users to see information that is incorrect, such as no support for Z-Wave Plus or Security.

Info not applicable:

  • Z-Wave Plus
  • Security
  • Node readiness
  • Node status (asleep, awake, dead)

Actions not supported:

  • Configuration
  • Re-Interview
  • Remove failed
  • Heal

Using the is_controller_node property of a node, we can omit the above when the connected controller device is selected. Depends on core PR home-assistant/core#66404.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Before:
image

After:
image

This is also the approach zwavejs2mqtt took for hiding the device info (they did not disable any actions though). See issue zwave-js/zwave-js-ui#1886. In comparison:

image

If there's a better way to communicate this, I'm open to implementing other ideas.

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 2ac0ad1 into home-assistant:dev Feb 14, 2022
@kpine kpine deleted the controller-node branch February 14, 2022 20:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants