New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another round of paper-dropdown -> mwc-select conversion #11674

Merged

bramkragten merged 6 commits into dev from another-round-of-dropbox

Feb 14, 2022

Member

bramkragten commented Feb 13, 2022

Proposed change

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (thank you!)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example configuration

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue or discussion:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
There is no commented out code in this PR.
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

homeassistant added the cla-signed label

zsarnett self-requested a review

February 14, 2022 04:55

zsarnett self-assigned this

zsarnett reviewed

View reviewed changes

src/panels/config/script/ha-script-editor.ts Outdated Show resolved Hide resolved

balloob reviewed

View reviewed changes

hassio/src/addon-view/config/hassio-addon-audio.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

hassio/src/addon-view/config/hassio-addon-audio.ts Outdated Show resolved Hide resolved

balloob reviewed

View reviewed changes

hassio/src/dialogs/datadisk/dialog-hassio-datadisk.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-trigger.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/config/automation/trigger/types/ha-automation-trigger-tag.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/config/automation/trigger/types/ha-automation-trigger-tag.ts Outdated Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/config/entities/entity-registry-settings.ts Outdated Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/config/integrations/integration-panels/zwave_js/zwave_js-logs.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/config/integrations/integration-panels/zwave_js/zwave_js-node-config.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/config/script/ha-script-editor.ts Outdated Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/lovelace/editor/config-elements/hui-alarm-panel-card-editor.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/lovelace/editor/config-elements/hui-calendar-card-editor.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/lovelace/editor/config-elements/hui-conditional-card-editor.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/lovelace/editor/config-elements/hui-generic-entity-row-editor.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/lovelace/editor/config-elements/hui-picture-entity-card-editor.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/lovelace/editor/config-elements/hui-picture-glance-card-editor.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/lovelace/editor/config-elements/hui-sensor-card-editor.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/lovelace/editor/config-elements/hui-statistics-graph-card-editor.ts Outdated Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/lovelace/editor/view-editor/hui-view-editor.ts Show resolved Hide resolved

balloob reviewed

View reviewed changes

src/panels/lovelace/editor/view-editor/hui-view-visibility-editor.ts Outdated Show resolved Hide resolved

balloob previously approved these changes

View reviewed changes

Member

balloob left a comment

Couple of missing imports. Rest looks good!

bramkragten added 5 commits

February 14, 2022 19:51


          Another round of paper-dropdown -> mwc-select conversion

349f45e


          ha-pick-language-row -> Lit


          Update hui-view-editor.ts

86a3ccc


          Cleanup imports

4c83787


          hassio

3f176ff


          Add explicit imports

990fdab

bramkragten dismissed balloob’s stale review via

990fdab

February 14, 2022 19:01

bramkragten force-pushed the another-round-of-dropbox branch from 6b86ebb to 990fdab Compare

February 14, 2022 19:01

bramkragten merged commit 523afe2 into dev

bramkragten deleted the another-round-of-dropbox branch

February 14, 2022 19:08

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.