Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Entity SElector when supplying multiple domains #11887

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

zsarnett
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

bramkragten
bramkragten previously approved these changes Feb 28, 2022
@@ -54,7 +54,7 @@ export class HaEntitySelector extends SubscribeMixin(LitElement) {
const entityDomain = computeStateDomain(entity);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const entityDomain = computeStateDomain(entity);
const entityDomain = computeStateDomain(entity);
const filterDomainIsArray = Array.isArray(filterDomain);

@balloob balloob merged commit 4f6d7ca into dev Mar 1, 2022
@balloob balloob deleted the fix-entity-selector-domains branch March 1, 2022 00:45
@balloob balloob mentioned this pull request Mar 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants