Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch history with no_attributes for entities that do not need them #12082

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 20, 2022

Proposed change

Dropping the attributes on the frontend in testing was much faster:

with - Run Time: real 1.891 user 0.041000 sys 0.053000
without - Run Time: real 0.074 user 0.034000 sys 0.040000

In testing all my entity history graphs on my production install load in < 1s now

This should be backwards compatible as the history api will ignore no_attributes if its not supported and we end up with the attributes in memory even if they aren't needed (as it currently functions).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bdraco bdraco marked this pull request as ready for review March 20, 2022 21:49
@bdraco
Copy link
Member Author

bdraco commented Mar 20, 2022

Pushing to a few more production installs now to double check. SFSG

bdraco added a commit to bdraco/mini-graph-card that referenced this pull request Mar 21, 2022
@bdraco
Copy link
Member Author

bdraco commented Mar 21, 2022

Testing seems solid.

@bdraco
Copy link
Member Author

bdraco commented Mar 21, 2022

Thanks 👍

@bdraco bdraco merged commit ddf1cc0 into home-assistant:dev Mar 21, 2022
@bdraco bdraco deleted the no_attr_frontend branch March 21, 2022 01:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants