Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jinja2 editor to template triggers/conditions #12365

Merged
merged 4 commits into from Apr 22, 2022
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Apr 20, 2022

Proposed change

Add the code editor with Jinja2 syntax to the template trigger and template condition.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment on lines 35 to 36
@property() public name;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is :)

Trigger event changed assume FormElement (from mwc-base, which our code editor isn't).
This we need to supply the bare minimum we depend upon, which is the name (used by the handleChangeEvent in the ha-automation-trigger-row.ts file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have the name on the element in ha-automation-trigger-row.ts without needing to add the property in the element. It will still set the name attribute and should be gettable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I'm a noob at frontend stuff and you would need to help / provide a hint me on this one.

It tried setting the name on HTML, but apparently: that is not enough to access it as a property. So, I guess I'm missing something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use can use .name=${"name"}

This will set it as a property. You are correct that it needs the Attr when setting it with just name=""

zsarnett
zsarnett previously approved these changes Apr 20, 2022
@zsarnett zsarnett enabled auto-merge (squash) April 22, 2022 01:32
@zsarnett zsarnett merged commit 6865791 into dev Apr 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the frenck-2022-0940 branch April 22, 2022 01:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants