Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show vacuum state in more-info dialog for StateVacuumEntity #12391

Merged
merged 2 commits into from Apr 23, 2022
Merged

Show vacuum state in more-info dialog for StateVacuumEntity #12391

merged 2 commits into from Apr 23, 2022

Conversation

yangqian
Copy link
Contributor

Breaking change

Proposed change

The old more-info dialog shows status of the legacy VacuumEntity.
However, the status attribute has been moved to the state of StateVacuumEntity.
The change will show the status of the vacuum, if not found, show the state.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@homeassistant
Copy link
Contributor

Hi @yangqian,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@zsarnett zsarnett enabled auto-merge (squash) April 23, 2022 06:23
@zsarnett zsarnett merged commit 7083659 into home-assistant:dev Apr 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vacuum state missing in the more-info dialog
3 participants