Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "m" keyboard shortcut to get to the create my link page #12451

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Apr 26, 2022

Breaking change

Proposed change

Can help our awesome super power users more effectively create my links

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

import {
QuickBarParams,
showQuickBar,
} from "../dialogs/quick-bar/show-dialog-quick-bar";
import { getMyRedirects } from "../panels/my/ha-panel-my";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import should be loaded dynamically.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

For a future PR we might want to consider adding this to quick bar too, to improve discoverability of this feature.

@ludeeus ludeeus merged commit 049ddd5 into dev Apr 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the m-for-my-link branch April 26, 2022 22:11
@frenck
Copy link
Member

frenck commented Apr 26, 2022

Sounds like a nice "Tip" too 😁

@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants