Add an application credentials display name #12720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
balloob
reviewed
May 18, 2022
src/translations/en.json
Outdated
| @@ -2865,12 +2865,14 @@ | |||
| "caption": "Add Application Credential", | |||
| "create": "Create", | |||
| "domain": "Integration", | |||
| "name": "Name for display", | |||
There was a problem hiding this comment.
Just name would be fine I think?
There was a problem hiding this comment.
hmm thinking now, it is going to confuse users I think? I wonder if we should only show name during updating, not creation.
There was a problem hiding this comment.
Renamed to Name.
bramkragten
reviewed
May 19, 2022
bramkragten
previously approved these changes
May 19, 2022
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
balloob
approved these changes
May 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add an application credentials display name
Core PR home-assistant/core#72053
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: