Fix multiple races in logbook subscriptions #12878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the user switched between tabs quickly there could be logbook messages delivered after we switch tabs but before we complete the unsubscribe - If they return to the tab to quickly the logbook data would not have been removed and the new subscription could get appended to it causing duplicate events to appear
This comment was marked as outdated.
This comment was marked as outdated.
|
One more issue is when you switch tabs and come back to the tab it show no rows for a second instead of loading |
Closed
3 tasks
balloob
reviewed
Jun 6, 2022
balloob
previously approved these changes
Jun 6, 2022
bdraco
commented
Jun 6, 2022
balloob
previously approved these changes
Jun 6, 2022
balloob
approved these changes
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
If the user switched between tabs quickly there could be
logbook messages delivered after we switch tabs but before
we complete the unsubscribe
If they return to the tab to quickly the logbook data would
not have been removed and the new subscription could get
appended to it causing duplicate events to appear
Catch the backend unsubscribing the stream when everything requested
is filtered (like the error seen here Live Logbook stopped being live (using Cloud/Google assistant?) core#72963 (comment))
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: