Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Energy Compare Translations #13055

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Fix Energy Compare Translations #13055

merged 2 commits into from
Jul 5, 2022

Conversation

zsarnett
Copy link
Contributor

@zsarnett zsarnett commented Jul 1, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@steverep
Copy link
Member

steverep commented Jul 1, 2022

@zsarnett FYI I have the same fix in #13004 along with many other bad or missing key fixes. If you have time, could use help getting rid of the rest of the errors.

@zsarnett
Copy link
Contributor Author

zsarnett commented Jul 1, 2022

That is a much larger PR 😄

@steverep
Copy link
Member

steverep commented Jul 1, 2022

Yeah, didn't start out that way, but I opened Pandora's box 😨

@bramkragten bramkragten merged commit e22dd0c into dev Jul 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the Fix-Energy-Translation branch July 5, 2022 09:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compare button in Energy Dashboard blank
4 participants