Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New more info light #14453

Merged
merged 19 commits into from
Jan 25, 2023
Merged

New more info light #14453

merged 19 commits into from
Jan 25, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Nov 25, 2022

Proposed change

CleanShot 2023-01-24 at 13 36 00

CleanShot 2023-01-24 at 13 36 08

CleanShot 2023-01-24 at 13 36 19

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added the needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview label Nov 28, 2022
@piitaya piitaya force-pushed the new-more-info-light branch 7 times, most recently from dc7a274 to 350cd21 Compare January 19, 2023 08:50
@piitaya piitaya force-pushed the new-more-info-light branch 5 times, most recently from 74c68ff to ffd82bf Compare January 24, 2023 08:18
@piitaya piitaya added this to the 2023.2 milestone Jan 24, 2023
@piitaya piitaya marked this pull request as ready for review January 24, 2023 12:38
@bramkragten bramkragten self-requested a review January 24, 2023 12:46
@bramkragten
Copy link
Member

bramkragten commented Jan 24, 2023

When a color is set, and not a CT, the indicator of the CT slider is at the bottom, can we hide the indicator when there is no CT value set?

@bramkragten bramkragten merged commit 7c4a421 into dev Jan 25, 2023
@bramkragten bramkragten deleted the new-more-info-light branch January 25, 2023 10:24
piitaya added a commit that referenced this pull request Jan 25, 2023
bramkragten pushed a commit that referenced this pull request Jan 25, 2023
Revert "New more info light (#14453)"

This reverts commit 7c4a421.
piitaya added a commit that referenced this pull request Feb 17, 2023
piitaya added a commit that referenced this pull request Feb 20, 2023
piitaya added a commit that referenced this pull request Feb 20, 2023
piitaya added a commit that referenced this pull request Feb 20, 2023
piitaya added a commit that referenced this pull request Feb 20, 2023
piitaya added a commit that referenced this pull request Feb 21, 2023
piitaya added a commit that referenced this pull request Feb 21, 2023
piitaya added a commit that referenced this pull request Feb 21, 2023
piitaya added a commit that referenced this pull request Feb 21, 2023
piitaya added a commit that referenced this pull request Feb 21, 2023
piitaya added a commit that referenced this pull request Feb 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants