Add "show_names" option to history graphs #14546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add the optional parameter "show_names" to history graph card to hide the names. This solves the use cases described in the linked issue. At the same time I removed the confusing "no-single" / "isSingleDevice" logic for a cleaner "showNames" approach. There was no longer any usage where looking at the amount of timelines to determine what to show made sense since via "no-single" usage that was anyway practically disabled.
The timeline in the more-info of course still hides the timeline name since here it is clear from the context what is shown (similar to the use cases described in the linked issue).
The default is still that names are always shown, so this is not a breaking change.
Note: Doc update will follow once we are aligned that we will merge in this new option.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: