Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "show_names" option to history graphs #14546

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

spacegaier
Copy link
Member

@spacegaier spacegaier commented Dec 4, 2022

Breaking change

Proposed change

Add the optional parameter "show_names" to history graph card to hide the names. This solves the use cases described in the linked issue. At the same time I removed the confusing "no-single" / "isSingleDevice" logic for a cleaner "showNames" approach. There was no longer any usage where looking at the amount of timelines to determine what to show made sense since via "no-single" usage that was anyway practically disabled.

The timeline in the more-info of course still hides the timeline name since here it is clear from the context what is shown (similar to the use cases described in the linked issue).

The default is still that names are always shown, so this is not a breaking change.

Note: Doc update will follow once we are aligned that we will merge in this new option.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

history-graph: do not show a name if only ONE graph is displayed (like it was before 2022.6.1)
2 participants