Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon for Heat off #14637

Closed
wants to merge 1 commit into from
Closed

Conversation

Mariusthvdb
Copy link
Contributor

@Mariusthvdb Mariusthvdb commented Dec 8, 2022

from thermometer (which has other meanings in HA frontend) to fire-off which is exactly what we are looking for, the flame is off in the heater

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

from thermometer (which has there meanings in HA frontend) to fire-off
@spacegaier spacegaier changed the title change icon for Heat off Change icon for Heat off Dec 8, 2022
@spacegaier
Copy link
Member

Can you please add a screenshot to show the before and after?

@Mariusthvdb
Copy link
Contributor Author

Mariusthvdb commented Dec 8, 2022

Can you please add a screenshot to show the before and after?

before is what's in the docs

Scherm­afbeelding 2022-12-08 om 13 37 25

changing that to

Scherm­afbeelding 2022-12-08 om 13 38 17

now see the current state Normal should also change to Off (uit) probably.

btw, as mentioned in de community, that image of the device classes really is obsolete now, due to all new state colors. Can we fix that please, it would help a lot, guiding the users to the correct color solutions after 2022.12 changes

also, if this device_class: heat is more for a generic temp situation, and not so much for a 'heatER', I need to kill this PR, and hope a new device_class: heater could be allowed

@Mariusthvdb
Copy link
Contributor Author

Mariusthvdb commented Dec 13, 2022

Paul, are you sure?
I expressed my doubts, and I feel that should be checked....

I was looking for a device_class: heating/er for the actual heaters to be on/off.
I think I mistakenly found this device_class: heat which really is a temperature class, just like device_class: cold is.

related chat in #devs_core https://discord.com/channels/330944238910963714/330990195199442944/1052163131054493777

@piitaya
Copy link
Member

piitaya commented Dec 13, 2022

The current device_class is not heater but heat : https://www.home-assistant.io/integrations/binary_sensor/
For moisture we have mdi:water-off and mdi-water so for me it makes sense to have similar rules for heat.

Adding heater can be discussed in core and then we can have differents icons for heat and heater 🙂

EDIT : I just looked at the cold device_class. We must follow the same rules for cold and heat. I thought heat was for a warning sensor (e.g. your sensor device is too hot).

@Mariusthvdb
Copy link
Contributor Author

Mariusthvdb commented Dec 13, 2022

exactly, glad you picked up my error/doubt.
Ive asked for addition of a new device_class in the devs_core, maybe you could jump in there too to confirm?
seems a fairly straightforward Pr in core, to be used in frontend.

Mariusthvdb added a commit to Mariusthvdb/core that referenced this pull request Dec 13, 2022
see related topic on new coloring for binaries, currently failing a class for heater/heating
home-assistant/frontend#14637 (comment)
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants