-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme color fixes #14672
Theme color fixes #14672
Conversation
I suspect that with this it will be messed up again :-( In the usual state all 3 icons are blue. In the off state it will take its colors from the theme, no matter whether state_colors is active or not. Now the door sensor and the light switch will become grey while the thermometer icon will stay blue. The configurable off- and unavailable colors should only be applied to the history graph. The entities icons should continue to take these colors from the theme. Anything else would destroy consistency! |
Please allow for these new colors to accept the value undefined (and make that the default) and then make all colors behave like they did before. |
Thanks for the feedback. For lovelace card, we will replace the Mode
|
|
|
Ok, this sounds reasonable. My blood pressure is already relaxing back to normal levels again. Thank you. |
How the new |
Same rules as before. |
I'm throwing this out on the color usage, but can also cover audio usage. Please remember about those who have trouble with seeing colors (color challenged versus color blind) and the hearing impaired. So if you are writing the changes you should remember there is a certain percentage of the world you maybe missing in your designs. Heaven forbid that groups who monitor software that drives web interfaces or programs used in everyday life send you legal/court papers forcing you to prove your designs are not discriminatory. Just food for those doing the design to think about. |
Proposed change
binary_sensor
.--rgb-state-unavailable-color
and--rgb-state-inactive-color
.Examples
Tile card
Button card with
state_color
option (active, inactive, unavailable)Button card without
state_color
option (active, inactive, unavailable)Button card with binary sensor color (alerting active, normal active, inactive)
Entities card with
state_color
optionEntities card without
state_color
optionHistory
Logbook
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: