Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary sensor color when off #14735

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Fix binary sensor color when off #14735

merged 1 commit into from
Dec 13, 2022

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Dec 13, 2022

Proposed change

Fix binary sensor when off in history
I also pushed some fixes and cleaning for battery and update entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added this to the 2022.12 milestone Dec 13, 2022
@ildar170975
Copy link
Contributor

@piitaya
Could you tell, will this PR solve #14665 (Fix a color for battery if "unknown") ?

@piitaya
Copy link
Member Author

piitaya commented Dec 13, 2022

No we didn't changed the behavior of the unknown state.

@bramkragten bramkragten merged commit d64bb98 into dev Dec 13, 2022
@bramkragten bramkragten deleted the binary_sensor_color_off branch December 13, 2022 11:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The color of binary sensors never changes (regardless of state)
3 participants