Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical option for tile card #14743

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

TheZoker
Copy link
Contributor

Breaking change

Proposed change

For some scenarios a vertical tile card is much more appealing. This PR adds a simple css class, that sets the flex-direction to column instead of row and centers the text. I also added a boolean switch to the tile card editor.
Some screenshots:



Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier
Copy link
Member

I am trying to understand the benefit of that layout. Isn't that always using more space than before?

@TheZoker
Copy link
Contributor Author

Yes true, but in some layouts it fits great.
For example here is the demo picture of the mushroom project:
image

In the top row it uses vertical cards and in my opinion it fits nicely here.

@JeffersonBledsoe
Copy link
Contributor

As a mushroom user who's slowly moving to tile as it becomes more feature complete, being able to set cards vertically for grid layouts is essential

@bramkragten bramkragten merged commit 06368a6 into home-assistant:dev Jan 25, 2023
@frenck
Copy link
Member

frenck commented Jan 25, 2023

This PR seems to be missing a documentation PR?

@piitaya
Copy link
Member

piitaya commented Jan 25, 2023

You're right ! I will push it 🙂

@TheZoker TheZoker deleted the tile_vertical branch January 25, 2023 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants