Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volume slider of assumed_state media player in entity row #14931

Merged
merged 2 commits into from Jan 23, 2023

Conversation

Drafteed
Copy link
Contributor

Proposed change

This small PR fixes cramped volume slider of assumed_state media player in entity row by hiding the stop button.

Before:

image

After:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@Drafteed Drafteed changed the title Fix assumed_state media player entity row with volume slider Fix volume slider of assumed_state media player in entity row Dec 31, 2022
@matthiasdebaat
Copy link
Collaborator

Thanks for this fix! It's still a bit cramped though. Might be better to move the mute and slider as a separate row below the buttons.

@Drafteed
Copy link
Contributor Author

Drafteed commented Jan 9, 2023

Thanks for this fix! It's still a bit cramped though. Might be better to move the mute and slider as a separate row below the buttons.

I think it will look weird and massive visually.

image

@Drafteed
Copy link
Contributor Author

Drafteed commented Jan 9, 2023

It's still a bit cramped though

We can also hide the next track button:

image

The "Stop" and "Next" buttons will remain available in the dialog box:

image

@matthiasdebaat
Copy link
Collaborator

The "Stop" and "Next" buttons will remain available in the dialog box:

Yeah, I agree. Let's continue with your original idea by hiding the stop button. Hiding the next button shouldn't impact entities that doesn't have the cramped space problem, for example ones without a volume slider.

CleanShot 2023-01-11 at 13 40 08@2x

@Drafteed
Copy link
Contributor Author

Drafteed commented Jan 11, 2023

@matthiasdebaat I've made changes. The stop/next buttons is hidden only when has the volume slider and assumed_state:

@bramkragten bramkragten enabled auto-merge (squash) January 23, 2023 20:05
@bramkragten bramkragten merged commit 38562a4 into home-assistant:dev Jan 23, 2023
@Drafteed Drafteed deleted the entiryrow-assumed-mp-fix branch January 23, 2023 20:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants