Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @fullcalendar to version 6.1.1 #14947

Merged
merged 6 commits into from
Feb 6, 2023
Merged

Conversation

steverep
Copy link
Member

@steverep steverep commented Jan 1, 2023

Proposed change

This is meant to replace #14914 from dependabot. After skimming dependabot issues, it seems this is failing because dependabot cannot yet handle a jump from no peer dependencies to having them. As a result, it seems to miss the fact that @fullcalendar/* plugins now all have @fullcalendar/core as a peer dependency. So the whole scope needs to update to v6 at once, plus the following:

  • According to the v6 release notes, manual style imports are no longer needed and CSS is injected via the JS, so I removed those occurences
  • Removed the internal @fullcalendar/common package (no v6)
  • Changed a couple occurrences of importing memoize to use memoize-one package instead (if these were purposely needed from fullcalendar, then they need to come from @fullcalendar/core/internal now)

Functionality seems fine but I admittedly did not even try to inspect for style differences. 😉 🦯

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@steverep steverep added the Dependencies Pull requests that update a dependency file label Jan 1, 2023
@bramkragten
Copy link
Member

bramkragten commented Jan 2, 2023

Checked the styling, and that is not quite there yet... Will look into it... they inject the styles at the top level (head) and as we use shadow dom that doesnt have effect there

CleanShot 2023-01-02 at 17 20 17

@bramkragten
Copy link
Member

Ugh...

https://github.com/fullcalendar/fullcalendar/blob/main/packages/core/src/styleUtils.ts

They should let you provide an element to apply the styles to...

@bramkragten
Copy link
Member

fullcalendar/fullcalendar#7118

@steverep
Copy link
Member Author

steverep commented Jan 2, 2023

Yeah, I was afraid of that… Should be a simple fix if they respond quickly though.

There's also a new Web component package from them, which I didn't look into yet. It may, or may not be useful to us.

@bramkragten
Copy link
Member

bramkragten commented Jan 2, 2023

Their web component doesn't use shadow DOM...

@steverep steverep marked this pull request as draft January 4, 2023 06:32
@steverep steverep mentioned this pull request Jan 26, 2023
9 tasks
@steverep steverep changed the title Bump @fullcalendar scope to version 6.0.2 Bump @fullcalendar to version 6.1.1 Feb 6, 2023
@steverep steverep marked this pull request as ready for review February 6, 2023 14:41
@steverep
Copy link
Member Author

steverep commented Feb 6, 2023

Upgraded to get their fix in 6.1, but again I'll defer to you on reviewing the style.

@bramkragten
Copy link
Member

Looks good!

@bramkragten bramkragten merged commit 791fd10 into dev Feb 6, 2023
@bramkragten bramkragten deleted the bump-fullcalendar-6.0.2 branch February 6, 2023 15:51
bram96 pushed a commit to bram96/frontend that referenced this pull request Feb 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants