-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @fullcalendar to version 6.1.1 #14947
Conversation
Ugh... https://github.com/fullcalendar/fullcalendar/blob/main/packages/core/src/styleUtils.ts They should let you provide an element to apply the styles to... |
Yeah, I was afraid of that… Should be a simple fix if they respond quickly though. There's also a new Web component package from them, which I didn't look into yet. It may, or may not be useful to us. |
Their web component doesn't use shadow DOM... |
Upgraded to get their fix in 6.1, but again I'll defer to you on reviewing the style. |
Looks good! |
Proposed change
This is meant to replace #14914 from dependabot. After skimming dependabot issues, it seems this is failing because dependabot cannot yet handle a jump from no peer dependencies to having them. As a result, it seems to miss the fact that
@fullcalendar/*
plugins now all have@fullcalendar/core
as a peer dependency. So the whole scope needs to update to v6 at once, plus the following:@fullcalendar/common
package (no v6)memoize
to usememoize-one
package instead (if these were purposely needed fromfullcalendar
, then they need to come from@fullcalendar/core/internal
now)Functionality seems fine but I admittedly did not even try to inspect for style differences. 😉 🦯
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: