Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current_humidity no shown on climate state card if also current_temperature is set #14993

Merged

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Jan 4, 2023

Proposed change

Also show current_humidity on climate if a current_temperature is available on the climate details card. Current behaviour is that humidity is only shown when there is no current_temperature.

Only current_humidity:
afbeelding

Only current_temperature:
afbeelding

This PR enables to show both if they are both available.
afbeelding

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@jbouwh jbouwh marked this pull request as ready for review January 4, 2023 17:53
@jbouwh jbouwh changed the title Also show current_humidity on climate Fix current_humidity no shown on climate detail card if also current_temperature is set Jan 4, 2023
@jbouwh jbouwh changed the title Fix current_humidity no shown on climate detail card if also current_temperature is set Fix current_humidity no shown on climate state card if also current_temperature is set Jan 5, 2023
@matthiasdebaat
Copy link
Collaborator

Where exploring showing related entities on the more info dialog #14502. This could be a fix for this issue too.

@jbouwh
Copy link
Contributor Author

jbouwh commented Jan 9, 2023

Where exploring showing related entities on the more info dialog #14502. This could be a fix for this issue too.

Except that the climate current humidity is not a separate entity but a property. But indeed if the device_id is shared, it could be be in improvement for other related sensor entities.

@bramkragten
Copy link
Member

This change will make the entity row too high, I'm ok with this in the more info dialog, but not for the entity row.

Co-authored-by: Paul Bottein <paul.bottein@gmail.com>
@jbouwh
Copy link
Contributor Author

jbouwh commented Jan 24, 2023

If have updated the screenshot in the description for the new code

@piitaya piitaya enabled auto-merge (squash) January 24, 2023 16:51
@piitaya piitaya merged commit 363ad36 into home-assistant:dev Jan 24, 2023
@jbouwh jbouwh deleted the climate-detail-show-current-humidity branch January 24, 2023 17:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants