Uses websocket to get sensor device class units #15014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
force-pushed
the
sensor_units_ws_api
branch
from
cdff33e
to
866cf1b
Compare
epenet
reviewed
Jan 6, 2023
bramkragten
previously approved these changes
Jan 6, 2023
bramkragten
reviewed
Jan 6, 2023
| @@ -177,6 +126,24 @@ const OVERRIDE_WEATHER_UNITS = { | |||
| wind_speed: ["ft/s", "km/h", "kn", "m/s", "mph"], | |||
| }; | |||
|
|
|||
| const CONVERTIBLE_UNITS_SENSOR_DEVICE_CLASS = new Set([ | |||
There was a problem hiding this comment.
Can we include this in the ws command from core?
bramkragten
reviewed
Jan 6, 2023
| export const SENSOR_DEVICE_CLASS_BATTERY = "battery"; | ||
| export const SENSOR_DEVICE_CLASS_TIMESTAMP = "timestamp"; | ||
|
|
||
| export type SensorDeviceClassUnits = { units: string[] }; |
There was a problem hiding this comment.
Something like
Suggested change
| export type SensorDeviceClassUnits = { units: string[] }; | |
| export type SensorDeviceClassUnits = { units: string[]; convertible: boolean; }; |
There was a problem hiding this comment.
That's what I suggested in the core PR
There was a problem hiding this comment.
Is there a plan to make use of this list for things other than unit conversion?
If it's only for unit conversion, then I think it's better to simply return an empty list when it's not convertible, as adjusted in home-assistant/core@9632158.
There was a problem hiding this comment.
I updated the endpoint et removed the hardcoded list in frontend
19 tasks
piitaya
added
backend merged
balloob
approved these changes
Jan 12, 2023
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fetch sensor device class units from core instead of hardcoded ones.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: