Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add/remove entities from map card editor #15087

Merged
merged 3 commits into from Jan 24, 2023

Conversation

karwosts
Copy link
Contributor

Proposed change

Fix the entity editor for map card, as reported in #15083.

There is a mismatch between expected value by the card editor (array of strings), and value provided by the entities picker (array of objects containing an entity: <string> value).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karwosts
Copy link
Contributor Author

Yes that seems like that works too. @spacegaier - do you want to review before we revert part of your change? Looks like you changed the map editor from array(entitiesConfigStruct) to array(entityId) and it seems like it broke the editor.

Any objection to going back, or what was the reason?

@bramkragten
Copy link
Member

I agree, that change should be reverted

@karwosts
Copy link
Contributor Author

Ok I reverted my change, and rolled back the previous change, and the card editor seems to work correctly again.

@karwosts karwosts requested a review from piitaya January 24, 2023 00:29
@piitaya piitaya merged commit 624bfbb into home-assistant:dev Jan 24, 2023
@karwosts karwosts deleted the fix-map-card-editor branch January 24, 2023 20:59
@xpsychic
Copy link

Dont think this is fixed yet?

Same issue, even on the latest version / patch.

Home Assistant 2023.1.7
Supervisor 2023.01.1
Operating System 9.5

Screenshot 2023-01-25 192455

@piitaya
Copy link
Member

piitaya commented Jan 25, 2023

The fix will be included in the 2023.2 first beta.

@xpsychic
Copy link

The fix will be included in the 2023.2 first beta.

Ah. thanks! I got the impression it was already taken care of in the version I’m running so thought I did something wrong. I will be patient then 😀

@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map card: Visual editor is not supported for this configuration (person.someone)
4 participants