New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix add/remove entities from map card editor #15087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should revert this change and use entitiesConfigStruct
instead of doing a mapping : https://github.com/home-assistant/frontend/pull/14792/files#diff-c4ffae6f9ea749b820dd8ea6323e67c420e9659567cc9e342926780c3e54e841L37-L39
Yes that seems like that works too. @spacegaier - do you want to review before we revert part of your change? Looks like you changed the map editor from array(entitiesConfigStruct) to array(entityId) and it seems like it broke the editor. Any objection to going back, or what was the reason? |
I agree, that change should be reverted |
Ok I reverted my change, and rolled back the previous change, and the card editor seems to work correctly again. |
The fix will be included in the 2023.2 first beta. |
Ah. thanks! I got the impression it was already taken care of in the version I’m running so thought I did something wrong. I will be patient then 😀 |
Proposed change
Fix the entity editor for map card, as reported in #15083.
There is a mismatch between expected value by the card editor (array of strings), and value provided by the entities picker (array of objects containing an
entity: <string>
value).Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: