Prevent optional time fields in ha-service-control from auto-enabling

[karwosts]

Proposed change

Services with an optional time parameter (using ha-selector-time) do not behave correctly, in that every time the service is loaded in the UI editor, the time parameter is always set to enabled. Other optional parameters are always disabled by default.

This means that every time an automation is loaded in the UI, a time: "00:00:00" will be added to a service that has an optional time parameter, even if user does not desire that parameter to be defined. Deleting it, and refreshing the page, will bring it right back again.

This occurs because when time is initialized (undefined by default), if localization requires an am/pm selector, it will instance the selector, default to AM, and then fire a "valueChanged" event with the value:

hours: NaN
minutes: NaN
seconds: NaN
ampm: "AM"

When ha-time-input gets this event, it coerces it into a value of "00:00:00" and itself fires a value changed up to its parent selector and service control. This event tricks the service control into thinking the time parameter exists with a value of 12am, and sets that parameter to enabled.

Suggest fix this in ha-time-input by treating valueChanged events with hours, minutes, and seconds as NaN as an undefined value, instead of "00:00:00". Then the time key remains correctly undefined after initialization, if the value is not already present in the yaml.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes Sonos update alarm automation adds a default time if none is given #15117
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io