Notification drawer #1536
Merged
Notification drawer #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
reviewed
Aug 6, 2018
| } | ||
|
|
||
| _openChanged(open) { | ||
| clearTimeout(openTimer); |
There was a problem hiding this comment.
I have not looked at all the code but this is wrong. This should be an instance variable.
balloob
reviewed
Aug 6, 2018
src/panels/lovelace/hui-root.js
Outdated
|
|
||
| connectedCallback() { | ||
| super.connectedCallback(); | ||
| this.addEventListener('close-notification-drawer', this._debouncedNotificationsClose); |
There was a problem hiding this comment.
This is overkill. Just have the button use a 2-way databinding to the notificationDrawer open ?
|
I did not realize that the PR was ready for review, looks good ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs work still, but wanted some eyes on this. Handles persistent_notifications and configurator entities as-is, but should be easy to modify to support other types, events, etc.