Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing 'Disarm' button #1549

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Fix for missing 'Disarm' button #1549

merged 2 commits into from
Aug 24, 2018

Conversation

gwww
Copy link
Contributor

@gwww gwww commented Aug 7, 2018

Disarm button does not show when in arming and disarming state.

Disarm button does not show when in `arming` and `disarming` state.
@homeassistant
Copy link
Contributor

Hi @gwww,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@BioSehnsucht
Copy link
Contributor

Relates to /issues/1415

@balloob
Copy link
Member

balloob commented Aug 7, 2018

Why would it need to show in disarming state ? It's already disarming so one cannot disarm again?

@BioSehnsucht
Copy link
Contributor

What state should be used for entry timers running (alarm will go to triggered state if not disarmed before entry timer expires) ? It's armed and going to alarm (maybe), but the siren isn't sounding so yet setting STATE_ALARM_TRIGGERED doesn't seem right. Should it be STATE_ALARM_ARMING for exit timer and STATE_ALARM_PENDING for entry timer? If so, what's the intended use of STATE_ALARM_DISARMING ?

@gwww
Copy link
Contributor Author

gwww commented Aug 7, 2018

Further to @BioSehnsucht comment, some alarm panels use pending when arming/disarming. The panel that we are working on (ElkM1), we chose to use arming and disarming states when arming/disarming. That seems more appropriate.

@balloob
Copy link
Member

balloob commented Aug 8, 2018

Well, this is not the place for a discussion about the available states of alarm panels. That would be in the architecture repo.

Disarm button visible on arming state.
@balloob balloob merged commit ec79e12 into home-assistant:master Aug 24, 2018
@ghost ghost removed the in progress label Aug 24, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants