Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve graph tooltips (#15887 #15887

Merged
merged 5 commits into from
Mar 30, 2023
Merged

Improve graph tooltips (#15887 #15887

merged 5 commits into from
Mar 30, 2023

Conversation

bramkragten
Copy link
Member

Proposed change

Tooltips will not show for all values of the hovered x axis. You dont have to hover the point, but the tooltip of the closest datapoint is show by default.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya
Copy link
Member

piitaya commented Mar 20, 2023

Should we use axis: "xy" to only select one chart at a time?

interaction: {
  mode: "nearest",
  axis: "xy",
  intersect: false,
},

@bramkragten
Copy link
Member Author

I don't think that is what we want? Especially if the y values are close it gets really hard then?

piitaya
piitaya previously approved these changes Mar 30, 2023
@bramkragten bramkragten added this to the 2023.4 milestone Mar 30, 2023
@bramkragten bramkragten changed the title Improve graph tooltips Improve graph tooltips (#15887 Mar 30, 2023
@bramkragten bramkragten merged commit dcac853 into dev Mar 30, 2023
@bramkragten bramkragten deleted the graph-tooltips branch March 30, 2023 14:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants