Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ha dialog header #16485

Merged
merged 16 commits into from May 10, 2023
Merged

Ha dialog header #16485

merged 16 commits into from May 10, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented May 9, 2023

Proposed change

Create a new component ha-dialog-header to replace ha-header-bar :

  • Use Material 3 padding for icons and title
  • Bottom border added on scroll
  • Text overflow for title
  • Simplify a lot some header bar css overrides
CleanShot.2023-05-09.at.13.30.42.mp4

CleanShot 2023-05-09 at 13 35 09

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya marked this pull request as ready for review May 9, 2023 13:27
@bramkragten bramkragten merged commit 3838d76 into dev May 10, 2023
6 checks passed
@bramkragten bramkragten deleted the ha-dialog-header branch May 10, 2023 12:34
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants