Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .nvmrc for GitHub actions #16569

Merged
merged 1 commit into from May 22, 2023
Merged

Use .nvmrc for GitHub actions #16569

merged 1 commit into from May 22, 2023

Conversation

steverep
Copy link
Member

Proposed change

... so that the node version is universally specified in one spot.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@steverep steverep added the GitHub Actions Pull requests that update GitHub Actions code label May 17, 2023
@steverep steverep mentioned this pull request May 22, 2023
9 tasks
Copy link
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bramkragten bramkragten merged commit 330aa23 into dev May 22, 2023
8 checks passed
@bramkragten bramkragten deleted the actions-nvmrc branch May 22, 2023 08:38
piitaya pushed a commit that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed GitHub Actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants