Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OS version for mounts to placeholder #16607

Merged
merged 2 commits into from May 25, 2023
Merged

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented May 23, 2023

Proposed change

We do not want folks translating the version, and this give us the ability to change it as well, without it affecting translations.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

mdegat01
mdegat01 previously approved these changes May 23, 2023
bramkragten
bramkragten previously approved these changes May 24, 2023
@ludeeus ludeeus dismissed stale reviews from bramkragten and mdegat01 via 4e8ae74 May 25, 2023 07:01
@bramkragten bramkragten merged commit dacdc62 into dev May 25, 2023
8 checks passed
@bramkragten bramkragten deleted the Change-mount-version branch May 25, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants