Convert climate water heaters to new water_heaters component #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
balloob
reviewed
Sep 17, 2018
|
|
||
| <div class$="[[computeClassNames(stateObj)]]"> | ||
|
|
||
| <template is="dom-if" if="[[supportsOn(stateObj)]]"> |
There was a problem hiding this comment.
You call supportsOn here but you don't have that method defined.
|
The entity registry one is fine, it just means that the backend entity does not define a unique ID. |
w1ll1am23
changed the title
|
@balloob I believe this is good to go. |
balloob
approved these changes
Sep 24, 2018
|
Run |
w1ll1am23
force-pushed
the
water_heater
branch
from
4bd8c31
to
d934e9a
Compare
|
This is ok to merge when water heaters have been added to the backend. |
|
backend MR home-assistant/core#17058 |
|
Going to merge this as it's not going to be in the way and the backend PR has emerged. |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support this effort home-assistant/core#13539 I have started working on this and have some of the initial work done. I am not a web dev so I don't really know what all is going on here, I just copied the climate stuff to water_heater.
Currently this is kinda working, but not perfectly. I am getting the following error when I click to bring up the more-infoPlease let me know if there is anything I am doing wrong or if you know how to fix the error.*NOTE: I am not seeing the operation mode selection option which I am assuming is from the error? But I am not sure.