L10N config-entries #1718
Merged
L10N config-entries #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
approved these changes
Oct 1, 2018
balloob
reviewed
Oct 1, 2018
src/translations/en.json
Outdated
| "manuf": "by {manufacturer}", | ||
| "hub": "Connected via", | ||
| "firmware": "Firmware: {version}", | ||
| "device_unavailable": "(device unavailable)", |
There was a problem hiding this comment.
Let's move the parentheses out of the translation.
balloob
reviewed
Oct 1, 2018
| @@ -716,8 +716,8 @@ | |||
| "manuf": "by {manufacturer}", | |||
| "hub": "Connected via", | |||
| "firmware": "Firmware: {version}", | |||
| "device_unavailable": "(device unavailable)", | |||
| "entity_unavailable": "(entity unavailable)" | |||
| "device_unavailable": "device unavailable", | |||
There was a problem hiding this comment.
Now you will need to add the parentheses back to the layout
balloob
approved these changes
Oct 1, 2018
balloob
reviewed
Oct 11, 2018
| @@ -19,7 +19,7 @@ function computeEntityName(hass, entity) { | |||
| /* | |||
| * @appliesMixin EventsMixin | |||
| */ | |||
| class HaDeviceCard extends EventsMixin(PolymerElement) { | |||
| class HaCeEntitiesCard extends EventsMixin(PolymerElement) { | |||
There was a problem hiding this comment.
We forgot to apply the localize mix in here.
Fix here: #1757
Now i need to consider what I want to do for 0.80 😢
There was a problem hiding this comment.
(verified that this was the only one in this PR)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial resolve #1593