-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Handle dict syntax in state trigger "for" #1725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that converting to string format is good 👍 |
I can't remember why we support the dict format btw 🤔 |
Ah the implementation is that the dict format is just passed as keyword args to the timedelta constructor. |
balloob
reviewed
Oct 3, 2018
seconds = 0, | ||
} = trgFor; | ||
hours = hours.toString(); | ||
minutes = minutes.toString().padStart(2, '0'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to add padStart
polyfill to compatability.js
balloob
approved these changes
Oct 5, 2018
ghost
removed
the
in progress
label
Oct 5, 2018
zsarnett
pushed a commit
to zsarnett/home-assistant-polymer
that referenced
this pull request
Oct 13, 2018
* Handle dict syntax in state trigger "for" * padStart polyfill
zsarnett
pushed a commit
to zsarnett/home-assistant-polymer
that referenced
this pull request
Oct 13, 2018
* Handle dict syntax in state trigger "for" * padStart polyfill
zsarnett
pushed a commit
to zsarnett/home-assistant-polymer
that referenced
this pull request
Oct 14, 2018
* Handle dict syntax in state trigger "for" * padStart polyfill
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our
for
configuration in our state trigger currently supports any of the following formats. This PR adds client handling to convert the dict format into string format so it can be rendered and edited in a single text field.Questions
numeric_state
as well, so maybe there's somewhere better for this logic to live, or maybe it should even be converted in the backend view.