-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace polymer paper-slider #18168
Replace polymer paper-slider #18168
Conversation
I got it fixed but the cutoff is due to the dialog. In other places there's no cutoff. |
Marked as draft for now |
I've fixed all places yesterday. Now tested more, and the only thing I can still notice is the cutoff pin in the more info dialog. |
.min=${this.min} | ||
.max=${this.max} | ||
.step=${this.step} | ||
labeled=${this.labeled} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labeled=${this.labeled} | |
.labeled=${this.labeled} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is incorrect. Labeled should be passed to ha-slider, it should be attached to the tag.
<ha-slider {}></ha-slider> => no pin on the slider
<ha-slider labeled {}></ha-slider => pin on the slider
Proposed change
Replace polymer paper-slider and use the brand new material web components.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: