Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restart in safe mode in restart dialog #18375

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Add restart in safe mode in restart dialog #18375

merged 3 commits into from
Oct 24, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Oct 24, 2023

Proposed change

Allow user to restart Home Assistant in safe mode.

CleanShot 2023-10-24 at 09 56 23

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@frenck frenck added the Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Oct 24, 2023
@bramkragten
Copy link
Member

bramkragten commented Oct 24, 2023

We also have to handle safe mode:

  • Show message to the user that they are in safe mode and how to get out of it
  • Don't load Lovelace resources

@piitaya
Copy link
Member Author

piitaya commented Oct 24, 2023

We also have to handle safe mode:

  • Show message to the user that they are in safe mode and how to get out of it
  • Don't load Lovelace resources

For Lovelace resources : #18382
For the message, I already put a note for the front-end meeting for the UX we want.

@bramkragten bramkragten merged commit 8350d71 into dev Oct 24, 2023
13 checks passed
@bramkragten bramkragten deleted the safe_mode branch October 24, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hacktoberfest Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants