Convert hui-vertical-stack-card to TypeScript/LitElement #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed to rebase previous branch and am taking my working changes and applying to a new branch based off of current master. Updated tslint.json to allow for prefixed `_` to variable names
ghost
added
the
balloob
reviewed
Oct 24, 2018
|
|
||
| set hass(hass: HomeAssistant) { | ||
| this._hass = hass; | ||
| for (const el of this.shadowRoot!.querySelectorAll("#root > *")) { |
There was a problem hiding this comment.
I realized by reading #1792 that hass can be set before we have rendered for the first time, so we should actually check if (this.shadowRoot)
There was a problem hiding this comment.
Actually, no, nevermind. shadowRoot is attached in the constructor. We might just not have rendered yet, which is fine because it means we just find nothing
balloob
approved these changes
Oct 24, 2018
|
Looks great 🎉 |
Merged
|
Fixed linting errors in #1849 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed to rebase previous branch and am taking my working changes and applying to a new branch based off of current master.
Updated tslint.json to allow for prefixed
_to variable names#1828