Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update dev tools yaml editor on entity change or submit #18575

Merged
merged 2 commits into from Nov 9, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Nov 9, 2023

Proposed change

#18134 introduced autoUpdate for YAML editor. autoUpdate must only be used with readOnly because if the format is not valid, it will clear the entire field value (e.g. adding a new line)
This PR only update the yaml editor on entity change or submit.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Co-authored-by: Simon Lamon <32477463+silamon@users.noreply.github.com>
Copy link
Contributor

@silamon silamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked if I did autoUpdate also on the dev tools event PR, but that's not the case. Thanks for fixing. 👍

@bramkragten bramkragten merged commit 7a619ad into dev Nov 9, 2023
13 checks passed
@bramkragten bramkragten deleted the fix_dev_tools_yaml_editor_not_valid branch November 9, 2023 09:00
bramkragten pushed a commit that referenced this pull request Nov 9, 2023
Co-authored-by: Simon Lamon <32477463+silamon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot edit state attributes in "Current entities"
3 participants