New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show numeric keypad if codeFormat is 'only digits'. #193
Conversation
lindstromhenrik
commented
Feb 2, 2017
- Revert remove keypad commit:58535ab
- Check if codeFormat is 'only digits' ('\d+')
@lindstromhenrik, thanks for your PR! By analyzing the history of the files in this pull request, we identified @persandstrom and @balloob to be potential reviewers. |
Hello @lindstromhenrik, When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es). The commits that are missing a linked GitHub account are the following:
Unfortunately, we are unable to accept this pull request until this situation is corrected. Here are your options:
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community. Thanks, I look forward to checking this PR again soon! ❤️ |
99ed7b6
to
e4a8f97
Compare
Hello @lindstromhenrik, When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es). The commits that are missing a linked GitHub account are the following:
Unfortunately, we are unable to accept this pull request until this situation is corrected. Here are your options:
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community. Thanks, I look forward to checking this PR again soon! ❤️ |
e4a8f97
to
5a08d7a
Compare
Hi @lindstromhenrik, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
5a08d7a
to
cf4812d
Compare
@lindstromhenrik any updates on this PR? |
I am not a fan of adding a keypad. Touch devices should already be able to show a keyboard when necessary right? |
@balloob the main use case is to be able to use the manual alarm panel together with the raspberry |
The idea of showing it when the code is only numbers is maybe a bit too intrusive for users running on mobile devices. I guess having the option of setting it in the configuration would be a better idea. |
They will show keyboard after the input is focused (extra click) There are some workarounds: http://stackoverflow.com/questions/19126856/make-input-type-password-use-number-pad-on-mobile-devices Since this is in more-info I think more buttons is better than less :) |
Hello @lindstromhenrik, When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es). The commits that are missing a linked GitHub account are the following:
Unfortunately, we are unable to accept this pull request until this situation is corrected. Here are your options:
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community. Thanks, I look forward to checking this PR again soon! ❤️ |
- Revert remove keypad commit:home-assistant@58535ab - Check if codeFormat is 'only digits' ('\d+')
We are not translating the docs now so remove the badge until we do