Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run script in script editor open more info if fields #19982

Merged
merged 2 commits into from Mar 4, 2024

Conversation

balloob
Copy link
Member

@balloob balloob commented Mar 4, 2024

Breaking change

Proposed change

In the script editor, the "Run script" menu option would raise an error if the script had fields defined, as the run script would not pass those fields in. This open the more info dialog so the user can enter the fields.

Information

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob added this to the 2024.3 milestone Mar 4, 2024
@piitaya piitaya merged commit 7ab2d14 into dev Mar 4, 2024
14 checks passed
@piitaya piitaya deleted the script-editor-run-script branch March 4, 2024 21:23
bramkragten pushed a commit that referenced this pull request Mar 6, 2024
* Run script in script editor open more info if fields

* Extract function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants