Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swing modes card feature #19999

Merged

Conversation

mukaschultze
Copy link
Contributor

@mukaschultze mukaschultze commented Mar 5, 2024

Proposed change

Recently (#19094), a new "fan modes" card feature was implemented into HASS, this PR implements its "swing modes" counterpart to have more control over climate devices without having to open the more info dialog

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

- type: tile
  entity: climate.hvac
  features:
    - style: dropdown
      swing_modes:
        - '2'
        - 'off'
        - '1'
        - auto
        - '3'
      type: climate-swing-modes
    - style: icons
      swing_modes:
        - auto
        - '1'
        - '3'
        - 'off'
        - '2'
      type: climate-swing-modes
- type: thermostat
  entity: climate.hvac
  features:
    - type: climate-swing-modes
      style: dropdown
      swing_modes:
        - auto
        - '1'
        - '2'
        - '3'
        - 'off'
    - style: icons
      swing_modes:
        - auto
        - '1'
        - '2'
        - '3'
        - 'off'
      type: climate-swing-modes

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mukaschultze

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Mar 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 5, 2024 23:37
@github-actions github-actions bot added the Design Related to Home Assistant design gallery label Mar 5, 2024
@mukaschultze mukaschultze marked this pull request as ready for review March 5, 2024 23:41
@mukaschultze mukaschultze changed the title feat: add swing modes card feature Add swing modes card feature Mar 5, 2024
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

@piitaya piitaya merged commit 279eeaa into home-assistant:dev Mar 12, 2024
16 checks passed
@frenck frenck added the Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Design Related to Home Assistant design gallery Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants