Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple-tooltip to 8.0.2 with RTL fix (remove patch) #20039

Merged
merged 2 commits into from Mar 12, 2024

Conversation

yosilevy
Copy link
Contributor

Breaking change

Proposed change

Update simple-tooltip to 8.0.2 with RTL fix (remove patch)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@yosilevy
Copy link
Contributor Author

This is my first package update so please review carefully... I've removed the patch I created since they fixed it in the repo and notified me.

@silamon
Copy link
Contributor

silamon commented Mar 10, 2024

You should also delete the patch itself from the yarn patch folder.

Copy link
Member

@steverep steverep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you delete the patch as well?

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 12, 2024 03:31
@yosilevy yosilevy marked this pull request as ready for review March 12, 2024 04:00
@home-assistant home-assistant bot requested a review from steverep March 12, 2024 04:00
@yosilevy
Copy link
Contributor Author

Done. Sorry for the delay.

@steverep steverep merged commit d56fe8a into home-assistant:dev Mar 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants