Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken state_color in Entities card #20077

Merged
merged 1 commit into from Mar 15, 2024

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Mar 13, 2024

Proposed change

Fix #20022, #19776 set attribute to false and thus no longer allows state_color to be provided as attribute. Seems to affect a bunch of installations, so it would be great if it can be cherry picked for 2023.3.1 or 2023.3.2.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

views:
  - title: Home
    cards:
      - type: entities
        entities:
          - entity: input_boolean.test
        footer:
          type: buttons
          entities:
            - entity: input_boolean.test
        state_color: false

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya added this to the 2024.3 milestone Mar 15, 2024
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll add it to the 2024.3 milestone to have it in a patch release 🙂

@piitaya piitaya merged commit b3718b8 into home-assistant:dev Mar 15, 2024
14 checks passed
@silamon
Copy link
Contributor Author

silamon commented Mar 22, 2024

@piitaya , this was not included in the latest patch release. Why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer Buttons in Entities Card (state color not changing)
2 participants