Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default icons for area and floors #20214

Merged
merged 4 commits into from Mar 28, 2024
Merged

Add default icons for area and floors #20214

merged 4 commits into from Mar 28, 2024

Conversation

bramkragten
Copy link
Member

Proposed change

Adds default icons for floors and areas that don't have an icon

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added this to the 2024.4 milestone Mar 27, 2024
@piitaya piitaya marked this pull request as draft March 28, 2024 12:01
@piitaya
Copy link
Member

piitaya commented Mar 28, 2024

Waiting for area icon from @matthiasdebaat suggestion

@bramkragten
Copy link
Member Author

Used the icon we already used in the target picker for example

@piitaya
Copy link
Member

piitaya commented Mar 28, 2024

It was only used in target picker. It's weird to have a full list of sofa in the area filter 😅

@piitaya
Copy link
Member

piitaya commented Mar 28, 2024

We checked with @matthiasdebaat, and we go for mdi:texture-box for area to avoid specific area icon by default (sofa for living room)
CleanShot 2024-03-28 at 15 53 34

@piitaya piitaya marked this pull request as ready for review March 28, 2024 14:55
@piitaya piitaya merged commit d3e6245 into dev Mar 28, 2024
13 checks passed
@piitaya piitaya deleted the default-icons-area-floor branch March 28, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants