Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zones on mobile, align mobile and non mobile view #20525

Merged
merged 2 commits into from Apr 15, 2024
Merged

Conversation

bramkragten
Copy link
Member

Proposed change

On mobile home zone editing didnt work.

Align UI from core config between mobile and non mobile

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@silamon silamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be great to refactor this page further so we don't need to simulate the click.

@bramkragten
Copy link
Member Author

It might be great to refactor this page further so we don't need to simulate the click.

Agree it is kinda a mess, especially with the mobile non-mobile differences

@bramkragten bramkragten merged commit 6516597 into dev Apr 15, 2024
13 checks passed
@bramkragten bramkragten deleted the mobile-zones branch April 15, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants