Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "Twitter" to "X (formerly Twitter)" #20694

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Rename "Twitter" to "X (formerly Twitter)" #20694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/panels/config/dashboard/ha-config-dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const randomTip = (hass: HomeAssistant, narrow: boolean) => {
href=${documentationUrl(hass, `/twitter`)}
target="_blank"
rel="noreferrer"
>Twitter</a
>X (formerly Twitter)</a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be added to the translation file. Then use the translation key in the links.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(@silamon if you request changes in your review, the PR is automatically put in to draft and a message is added by the bot explaining why etc)

>`,
discord: html`<a
href=${documentationUrl(hass, `/join-chat`)}
Expand Down
2 changes: 1 addition & 1 deletion src/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6816,7 +6816,7 @@
"forums": "Home Assistant forums",
"open_home_newsletter": "Building the Open Home newsletter",
"discord": "Discord chat",
"twitter": "Twitter",
"twitter": "X (formerly Twitter)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also change the key to x. It will invalidate the translation for all languages.

"playstore": "Get it on Google Play",
"appstore": "Download on the App Store"
},
Expand Down