Pin Lit-HTML and Lit-Element #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pins Lit-HTML to 0.12.0 and Lit-Element to 0.6.2 (which depends on Lit-HTML 0.12).
Lit HTML had a breaking change in a patch release (how directives are wrapped) and this caused troubles with how they have pinned their deps, pulling in wrong Lit. As we also use MWC, which depends on Lit, and is pulling in the wrong version, things started breaking.
By pinning it, we can work with 0.12.0 until material-components/material-web#164 is merged and released.